chore(middleware-flexible-checksums): use object for requestAlgorithmMember #6698
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
force-pushed
the
flex-checks-request-algorithm-member-object
branch
from
6c40950
to
f7800dd
Compare
|
Blocked on lack of support for Object in CodegenUtils |
|
Pausing this to avoid releasing during Thanksgiving and re:Invent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
Switches to using object for requestAlgorithmMember to avoid future confusion that requestAlgorithmMember and requestAlgorithmMemberHttpHeader can exist independently of each other
Testing
CI, as this PR just populates the middleware config.
The value will be consumed, and tested in #6492
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.