Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prettify cucumber tests #706

Merged
merged 2 commits into from
Jan 10, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 10, 2020

Issue #, if available:
Refs: #687

Description of changes:

  • The cucumber tests weren't prettied as we wanted to compare them with v2 during initial development
  • The tests can now be prettified given that we're pretty confident of them running on new clients in chore: run integration tests on available clients #687, and will be posting one big PR

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit 5881e45 into aws:smithy-codegen Jan 10, 2020
@trivikr trivikr deleted the prettify-cucumber-tests branch January 10, 2020 02:27
@lock
Copy link

lock bot commented Jan 17, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants