-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update clients with correct endpoint prefix #720
fix: update clients with correct endpoint prefix #720
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
84c317e
to
b44c9f9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@mtdowling The last commit was regenerating clients with new endpoints. Review here for related changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! This should be considered a temporary fix until we figure out how to either restructure the endpoints.json file to be keyed off of service ID or some other mechanism where individual teams don't need to maintain this mapping.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
serviceId
toendpointPrefix
grepped from in old C2J models, so thatEndpointGenerator
can consumeendpoints.json
properly which is indexed by endpoint prefixsslCommonName
overhostname
fromendpoints.json
when available.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.