-
Notifications
You must be signed in to change notification settings - Fork 618
feat: add isValidHostname function #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## smithy-codegen #774 +/- ##
==================================================
+ Coverage 92.33% 92.34% +<.01%
==================================================
Files 140 141 +1
Lines 2753 2756 +3
Branches 478 478
==================================================
+ Hits 2542 2545 +3
Misses 211 211
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I don't understand the JavaScript ecosystem well enough, but this is too small of a package IMO. Could these 4 lines of code can be added to an existing package?
This comment has been minimized.
This comment has been minimized.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Adds validHostname function for checking hostname validity. To be used for host prefixing. Ref: smithy-lang/smithy-typescript/pull/104
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.