Skip to content

feat: add isValidHostname function #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 22, 2020

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Jan 22, 2020

Adds validHostname function for checking hostname validity. To be used for host prefixing. Ref: smithy-lang/smithy-typescript/pull/104

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation

This comment has been minimized.

@codecov-io
Copy link

codecov-io commented Jan 22, 2020

Codecov Report

Merging #774 into smithy-codegen will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           smithy-codegen     #774      +/-   ##
==================================================
+ Coverage           92.33%   92.34%   +<.01%     
==================================================
  Files                 140      141       +1     
  Lines                2753     2756       +3     
  Branches              478      478              
==================================================
+ Hits                 2542     2545       +3     
  Misses                211      211
Impacted Files Coverage Δ
packages/protocol-http/src/isValidHostname.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd794e4...e0aa811. Read the comment docs.

Copy link
Member

@mtdowling mtdowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I don't understand the JavaScript ecosystem well enough, but this is too small of a package IMO. Could these 4 lines of code can be added to an existing package?

@srchase srchase requested a review from mtdowling January 22, 2020 22:16
@aws-sdk-js-automation

This comment has been minimized.

@trivikr trivikr changed the title Feat: adds validHostname function feat: add isValidHostname function Jan 22, 2020
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit db2a498 into aws:smithy-codegen Jan 22, 2020
@srchase srchase deleted the util-valid-hostname branch January 22, 2020 23:33
@lock
Copy link

lock bot commented Jan 30, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants