Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "normalize" function to the config definition and remove that responsibility from the "apply" function #94

Closed
wants to merge 5 commits into from

Conversation

jeskew
Copy link
Contributor

@jeskew jeskew commented Jan 4, 2018

This PR separates the current responsibilities of the apply function in a config property definition into two separate steps: a normalize function that converts user input to the subtype expected by the SDK and an apply function that modifies the middleware stack.

This allows two optimizations:

  1. We can forgo calling the normalizer if the user did not supply anything for a property.
  2. The apply function can be deferred until the config is fully normalized and hydrated with defaults. This smaller scope for apply is more or less equivalent to what a middleware customization would do, so we can look at removing apply once that customization type is available.

@chrisradek
Copy link
Contributor

Closed as part of #142

@chrisradek chrisradek closed this Oct 17, 2018
@lock
Copy link

lock bot commented Sep 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants