Fixes S3 issue where aborted requests would trigger a bucket region l…

…ookup in browsers (#1608)

* Fixes S3 issue where aborted requests would trigger a bucket region lookup in browsers

* Prevent Timeout errors from triggering a region lookup in browsers

.changes/next-release/bugfix-S3-cba1d450.json

@@ -0,0 +1,5 @@
+{
+  "type": "bugfix",
+  "category": "S3",
+  "description": "Updates S3 client to no longer attempt to determine a bucket's region when a request is aborted."
+}

lib/event_listeners.js

@@ -282,12 +282,16 @@ AWS.EventListeners = {
       }
 
       function error(err) {
-        resp.error = AWS.util.error(err, {
-          code: 'NetworkingError',
-          region: resp.request.httpRequest.region,
-          hostname: resp.request.httpRequest.endpoint.hostname,
-          retryable: true
-        });
+        if (err.code !== 'RequestAbortedError') {
+          var errCode = err.code === 'TimeoutError' ? err.code : 'NetworkingError';
+          err = AWS.util.error(err, {
+            code: errCode,
+            region: resp.request.httpRequest.region,
+            hostname: resp.request.httpRequest.endpoint.hostname,
+            retryable: true
+          });
+        }
+        resp.error = err;
         resp.request.emit('httpError', [resp.error, resp], function() {
           done();
         });

lib/service.js

@@ -354,6 +354,7 @@ AWS.Service = inherit({
    * @api private
    */
   retryableError: function retryableError(error) {
+    if (this.timeoutError(error)) return true;
     if (this.networkingError(error)) return true;
     if (this.expiredCredentialsError(error)) return true;
     if (this.throttledError(error)) return true;
@@ -368,6 +369,13 @@ AWS.Service = inherit({
     return error.code === 'NetworkingError';
   },
 
+  /**
+   * @api private
+   */
+  timeoutError: function timeoutError(error) {
+    return error.code === 'TimeoutError';
+  },
+
   /**
    * @api private
    */