allow sending body for GET request of REST services (#2574)

* allow sending body for GET request of REST services * not set stringified empty object in body for rest json
aws · Mar 18, 2019 · f9ef9b6 · f9ef9b6
1 parent aca7cf9
commit f9ef9b6
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 5 deletions.
diff --git a/.changes/next-release/bugfix-Paginator-b5c4816c.json b/.changes/next-release/bugfix-Paginator-b5c4816c.json
@@ -0,0 +1,5 @@
+{
+  "type": "bugfix",
+  "category": "Paginator",
+  "description": "fix the issue where paginator keys are ignored in GET requests"
+}
diff --git a/lib/protocol/rest_json.js b/lib/protocol/rest_json.js
@@ -24,7 +24,10 @@ function populateBody(req) {
       }
     }
   } else {
-    req.httpRequest.body = builder.build(req.params, input);
+    var body = builder.build(req.params, input);
+    if (body !== '{}') { //don't send empty object
+      req.httpRequest.body = body;
+    }
     applyContentTypeHeader(req);
   }
 }
@@ -42,8 +45,8 @@ function applyContentTypeHeader(req, isBinary) {
 function buildRequest(req) {
   Rest.buildRequest(req);
 
-  // never send body payload on GET/HEAD/DELETE
-  if (['GET', 'HEAD', 'DELETE'].indexOf(req.httpRequest.method) < 0) {
+  // never send body payload on HEAD/DELETE
+  if (['HEAD', 'DELETE'].indexOf(req.httpRequest.method) < 0) {
     populateBody(req);
   }
 }

diff --git a/test/protocol/rest_json.spec.js b/test/protocol/rest_json.spec.js
diff --git a/test/services/cloudsearchdomain.spec.js b/test/services/cloudsearchdomain.spec.js