Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should retry Route53 requests that get PriorRequestNotComplete errors #1166

Closed
Answashe opened this issue Oct 4, 2016 · 4 comments · Fixed by #1168
Closed

Should retry Route53 requests that get PriorRequestNotComplete errors #1166

Answashe opened this issue Oct 4, 2016 · 4 comments · Fixed by #1168
Labels
feature-request A feature should be added or improved.

Comments

@Answashe
Copy link

Answashe commented Oct 4, 2016

http://docs.aws.amazon.com/Route53/latest/DeveloperGuide/DNSLimitations.html#limits-api-requests has a description of the PriorRequestNotComplete error. In most cases this can be retried with the normal exponential backoff strategy. In fact, that's what boto does.

boto works a little differently in that its retry behavior is defined as data instead of code, but see boto/botocore#682 for the corresponding change in boto.

@Answashe
Copy link
Author

Answashe commented Oct 4, 2016

I think the easy way to do this would be to modify the Route53 service to override retryableError similar to the way the S3 service does

@LiuJoyceC
Copy link
Contributor

Hi @Answashe
Thanks for the suggestion! I will mark this as a feature request.

@LiuJoyceC LiuJoyceC added the feature-request A feature should be added or improved. label Oct 6, 2016
@LiuJoyceC
Copy link
Contributor

Hi @Answashe
The feature has been merged in and is available immediately on Github, and will be available from NPM in the next release. Thanks again for bringing this to our attention!

@lock
Copy link

lock bot commented Sep 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants