Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not retrying when PriorRequestNotComplete #1001

Closed
kcolemangt opened this issue Dec 15, 2016 · 1 comment · Fixed by #1002
Closed

Not retrying when PriorRequestNotComplete #1001

kcolemangt opened this issue Dec 15, 2016 · 1 comment · Fixed by #1002

Comments

@kcolemangt
Copy link
Contributor

AWS General Reference for API Retries claims SDKs implement automatic retry logic and instructs non-SDK users to retry requests that receive throttling errors. SDK for Go API Reference recommends an exponential backoff retry algorithm for the “PriorRequestNotComplete” error code.

SDK should use configured retry options upon receiving “PriorRequestNotComplete” error code.

Each AWS SDK implements automatic retry logic.
http://docs.aws.amazon.com/general/latest/gr/api-retries.html

If you're not using an AWS SDK, you should retry original requests that receive server (5xx) or throttling errors.
http://docs.aws.amazon.com/general/latest/gr/api-retries.html

PriorRequestNotComplete
If Amazon Route 53 can't process a request before the next request arrives,
it will reject subsequent requests for the same hosted zone and return an
HTTP 400 error (Bad request). If Amazon Route 53 returns this error repeatedly
for the same request, we recommend that you wait, in intervals of increasing
duration, before you try the request again.
http://docs.aws.amazon.com/sdk-for-go/api/service/route53/#example_Route53_ChangeResourceRecordSets

This has already been implemented in another AWS SDK:
aws/aws-sdk-js#1166
https://github.com/aws/aws-sdk-js/blob/b0de518dab2ceb08a62ad2abe59a222b62d90003/lib/services/route53.js

I will submit a PR.

@jasdel
Copy link
Contributor

jasdel commented Dec 15, 2016

Thanks for taking the time to find and add the throttle error code to the SDK @kcolemangt. Let us know if you find anything else, or have additional feedback.

@awstools awstools mentioned this issue Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants