-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Token file web identity credentials #2737
feat: Token file web identity credentials #2737
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2737 +/- ##
==========================================
+ Coverage 96.89% 96.92% +0.03%
==========================================
Files 289 297 +8
Lines 8755 8888 +133
Branches 1648 1662 +14
==========================================
+ Hits 8483 8615 +132
- Misses 272 273 +1
Continue to review full report at Codecov.
|
The Node10 test failed in Travic because your unit tests were run in browser tests. You can get rid of them by only run you tests in Node tests like here |
Nice. I don't have more feedback 👍. Just a reminder, we also need a |
The typings were added in commit e3086ce |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve again!
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Checklist
npm run test
passes.d.ts
file is updatednpm run add-change