Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Token file web identity credentials #2737

Merged
merged 49 commits into from
Aug 23, 2019
Merged

feat: Token file web identity credentials #2737

merged 49 commits into from
Aug 23, 2019

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 21, 2019

Checklist
  • npm run test passes
  • .d.ts file is updated
  • changelog is added, npm run add-change

@codecov-io
Copy link

codecov-io commented Jun 25, 2019

Codecov Report

Merging #2737 into master will increase coverage by 0.03%.
The diff coverage is 95.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2737      +/-   ##
==========================================
+ Coverage   96.89%   96.92%   +0.03%     
==========================================
  Files         289      297       +8     
  Lines        8755     8888     +133     
  Branches     1648     1662      +14     
==========================================
+ Hits         8483     8615     +132     
- Misses        272      273       +1
Impacted Files Coverage Δ
lib/credentials/process_credentials.js 100% <100%> (+3.44%) ⬆️
lib/credentials/shared_ini_file_credentials.js 97.61% <100%> (-0.26%) ⬇️
lib/util.js 94.71% <100%> (+0.14%) ⬆️
lib/node_loader.js 90% <50%> (-1.18%) ⬇️
...credentials/token_file_web_identity_credentials.js 96% <96%> (ø)
lib/publisher/index.js 100% <0%> (ø) ⬆️
lib/publisher/configuration.js 100% <0%> (ø) ⬆️
lib/s3/managed_upload.js 94.05% <0%> (ø) ⬆️
lib/credentials/chainable_temporary_credentials.js 100% <0%> (ø) ⬆️
clients/applicationinsights.js 100% <0%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9e33bc...3286c72. Read the comment docs.

lib/node_loader.js Outdated Show resolved Hide resolved
@AllanZhengYP
Copy link
Contributor

The Node10 test failed in Travic because your unit tests were run in browser tests. You can get rid of them by only run you tests in Node tests like here

@trivikr trivikr changed the title [WIP] feat: Token file web identity credentials feat: Token file web identity credentials Jun 27, 2019
@AllanZhengYP
Copy link
Contributor

Nice. I don't have more feedback 👍. Just a reminder, we also need a d.ts file for the credential provider. Other than this, this PR looks good to me.

@trivikr
Copy link
Member Author

trivikr commented Jun 28, 2019

The typings were added in commit e3086ce

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve again!

@trivikr trivikr merged commit 75690eb into aws:master Aug 23, 2019
@trivikr trivikr deleted the assume_role_with_web_identity_credentials branch August 23, 2019 17:47
@lock
Copy link

lock bot commented Aug 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants