Fix nextPage typing in requests #3298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fixes the return type of the `nextPage()` method. Before, it would return `Request<D, E>|void` which is hard to work with, because you couldn't runtime test for `void` (everything can be void). This change splits up the definition into two overloads: one without a callback provided that returns `Request<D, E> | null` and a second for the callback version that always returns `void`. This also matches the documentation in the implementation now.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
kirananto
approved these changes
Sep 28, 2020
siddsriv
approved these changes
Sep 7, 2023
|
Much needed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixes the return type of the
nextPage()method. Before, it wouldreturn
Request<D, E>|voidwhich is hard to work with, because youcouldn't runtime test for
void(everything can be void). This changesplits up the definition into two overloads: one without a callback
provided that returns
Request<D, E> | nulland a second for thecallback version that always returns
void. This also matches thedocumentation in the implementation now.
Checklist
npm run testpasses.d.tsfile is updatednpm run add-change