Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix UnknownEndpoint exception not thrown in Node14 #3396

Merged
merged 1 commit into from
Aug 14, 2020
Merged

fix UnknownEndpoint exception not thrown in Node14 #3396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/next-release/bugfix-ErrorParser-eb144db2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"type": "bugfix",
"category": "ErrorParser",
"description": "fix UnknownEndpoint exception not thrown in Node14(#3393)"
}
8 changes: 7 additions & 1 deletion lib/event_listeners.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,13 @@ AWS.EventListeners = {
add('EXTRACT_REQUEST_ID', 'extractError', AWS.util.extractRequestId);

add('ENOTFOUND_ERROR', 'httpError', function ENOTFOUND_ERROR(err) {
if (err.code === 'NetworkingError' && err.errno === 'ENOTFOUND') {
function isDNSError(err) {
return err.errno === 'ENOTFOUND' ||
typeof err.errno === 'number' &&
typeof AWS.util.getSystemErrorName === 'function' &&
['EAI_NONAME', 'EAI_NODATA'].indexOf(AWS.util.getSystemErrorName(err.errno) >= 0);
}
if (err.code === 'NetworkingError' && isDNSError(err)) {
var message = 'Inaccessible host: `' + err.hostname +
'\'. This service may not be available in the `' + err.region +
'\' region.';
Expand Down
1 change: 1 addition & 0 deletions lib/node_loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ util.clientSideMonitoring = {
configProvider: require('./publisher/configuration'),
};
util.iniLoader = require('./shared-ini').iniLoader;
util.getSystemErrorName = require('util').getSystemErrorName;

var AWS;

Expand Down
18 changes: 18 additions & 0 deletions test/event_listeners.spec.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.