Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export client config interface on root as ConfigurationOptions #3485

Merged
merged 1 commit into from
Oct 8, 2020
Merged

export client config interface on root as ConfigurationOptions #3485

merged 1 commit into from
Oct 8, 2020

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Oct 8, 2020 •
edited
Loading

Resolves #3453

Checklist
  • npm run test passes
  • .d.ts file is updated
  • changelog is added, npm run add-change
  • run bundle exec rake docs:api and inspect doc/latest/index.html if documentation is changed
  • run npm run integration if integration test is changed
  • [] non-code related change (markdown/git settings etc)

/cc @MrArnoldPalmer

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-v2-github
  • Commit ID: f22870b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ajredniwja ajredniwja merged commit f4c66c7 into aws:master Oct 8, 2020
@shivlaks
Copy link

shivlaks commented Oct 8, 2020

@AllanFly120 - we also ran into this with RetryDelayOptions in addition to ConfigurationOptions in aws/aws-cdk#10499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajredniwja ajredniwja ajredniwja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TS Type Breaking Changes
4 participants
@AllanZhengYP @aws-sdk-js-automation @shivlaks @ajredniwja