Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: switch replaceAll with replace in change-creator #3753

Merged
merged 2 commits into from
May 7, 2021
Merged

fix: switch replaceAll with replace in change-creator #3753

merged 2 commits into from
May 7, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 5, 2021

Fixes: #3751

Testing

The npm run add-change was added on Node.js v8.11.3

$ node -v
v8.17.0

$ npm run add-change
...
Valid types are "feature" or "bugfix"
type: bugfix

Category can be a service identifier or something like: Paginator
category: changelog

A brief description of your change.
description: switch replaceAll with replace in change-creator

File created at /Users/trivikr/workspace/aws-sdk-js/.changes/next-release/bugfix-changelog-e6277489.json
Checklist
  • changelog is added, npm run add-change

@trivikr trivikr requested review from AllanZhengYP and ajredniwja and removed request for AllanZhengYP May 5, 2021 19:51
@trivikr trivikr merged commit 4d20e3a into aws:master May 7, 2021
@trivikr trivikr deleted the change-creator-replaceAll branch May 7, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajredniwja ajredniwja ajredniwja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm run add-change works only in Node.js 15.x+
2 participants
@trivikr @ajredniwja