fix invalid signature error when consecutive slashes exists in path #4051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same happens for redundant port number (like :443 for HTTPS URLs). |
kuhe
reviewed
Apr 12, 2022
| it('should fix invalid path with consecutive slashes', function () { | ||
| expect(AWS.util.uriNormalizePath('a//c')).to.equal('a/c'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
does this function include handling the // in https://?
|
Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue. |
github-actions
bot
added
closing-soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to aws/aws-sdk-js-v3#3408, this change fixes invalid signature error when consecutive slashes exists in the reques path. This change also normalizes the relative pathes.
Checklist
npm run testpassesnpm run add-change