Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose fetchMetadataToken to AWS.MetadataService #4240

Merged
merged 1 commit into from
May 22, 2024
Merged

Expose fetchMetadataToken to AWS.MetadataService #4240

merged 1 commit into from
May 22, 2024

Conversation

matthewzhaocc
Copy link
Contributor

This PR exposes the fetchMetadataToken to the AWS.MetadataService class. This helps with the usability of the workaround in 3584

Checklist
  • [ x] .d.ts file is updated
  • [ x] changelog is added, npm run add-change
  • [ x] run bundle exec rake docs:api and inspect doc/latest/index.html if documentation is changed

@matthewzhaocc matthewzhaocc requested a review from a team as a code owner October 15, 2022 17:13
@Kaileem26
Copy link

This PR exposes the fetchMetadataToken to the AWS.MetadataService class. This helps with the usability of the workaround in 3584

Checklist
  • [ x] .d.ts file is updated
  • [ x] changelog is added, npm run add-change
  • [ x] run bundle exec rake docs:api and inspect doc/latest/index.html if documentation is changed

@Kaileem26 Kaileem26 mentioned this pull request Oct 25, 2022
Closed
@kuhe
Copy link
Contributor

kuhe commented May 22, 2024

fyi AWS SDK JSv3 has a metadata service now and it prefers IMDSv2

@kuhe kuhe merged commit 9fa11fe into aws:master May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhe kuhe kuhe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewzhaocc @Kaileem26 @kuhe