Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update getEndpointSuffix for us-isof-south-1 #4674

Merged
merged 2 commits into from
Aug 30, 2024
Merged

update getEndpointSuffix for us-isof-south-1 #4674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
862c76e
update getEndpointSuffix for us-isof-south-1
siddsriv Aug 30, 2024
af94bb0
chore: add changelog
siddsriv Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changes/next-release/bugfix-region-endpoint-0496c4f3.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"type": "bugfix",
"category": "region endpoint",
"description": "add endpoint suffix for a region"
}
1 change: 1 addition & 0 deletions lib/region_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ function getEndpointSuffix(region) {
'^us\\-iso\\-\\w+\\-\\d+$': 'c2s.ic.gov',
'^us\\-isob\\-\\w+\\-\\d+$': 'sc2s.sgov.gov',
'^eu\\-isoe\\-west\\-1$': 'cloud.adc-e.uk',
'^us\\-isof\\-\\w+\\-\\d+$': 'csp.hci.ic.gov',
};
var defaultSuffix = 'amazonaws.com';
var regexes = Object.keys(regionRegexes);
Expand Down
4 changes: 4 additions & 0 deletions test/region_config.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,10 @@ describe('region_config.js', function() {
it('resolves the endpoint suffix for eu-isoe-west-1', function() {
expect(getEndpointSuffix('eu-isoe-west-1')).to.equal('cloud.adc-e.uk');
});

it('resolves the endpoint suffix for us-isof-south-1', function() {
expect(getEndpointSuffix('us-isof-south-1')).to.equal('csp.hci.ic.gov');
});
});

describe('region_config_data.json', function() {
Expand Down