Adding the ability to perform strict validation. #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the JavaScript SDK to allow it to perform strict validation client-side using the enum, min, max, and pattern traits. Validating based on these traits are (and should be) an opt-in for customers as overly strict client-side validation can cause unnecessary inconvenience when a service team relaxes any validation constraints. However, being able to perform strict validation would enable tooling that utilizes the JavaScript SDK to have more confidence on whether or not inputs and outputs match a service's model at a point in time. Note that this commit does not switch the JS SDK over to using the regular models without minification.
Updating the SDK to now validate min by default. You can now provide a map to specify which opt-in validations to perform, including allowing the ability to disable min validation.
|
|
mtdowling
added a commit
that referenced
this pull request
Jan 7, 2016
Adding the ability to perform strict validation.
chrisradek
added a commit
that referenced
this pull request
Jan 12, 2016
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the JavaScript SDK to allow it to perform strict
validation client-side using the enum, min, max, and pattern traits.
Validating based on these traits are (and should be) an opt-in for
customers as overly strict client-side validation can cause unnecessary
inconvenience when a service team relaxes any validation constraints.
However, being able to perform strict validation would enable tooling
that utilizes the JavaScript SDK to have more confidence on whether or
not inputs and outputs match a service's model at a point in time.
Note that this commit does not switch the JS SDK over to using the
regular models without minification.
/cc @chrisradek @jeskew