feat: add support for DDB Mapper getItem overloads that specify primary key(s)
#1583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
A new generated diff is ready to view.
|
Affected ArtifactsNo artifacts changed size |
lauzadis
approved these changes
Apr 23, 2025
0marperez
approved these changes
Apr 24, 2025
| lowLevelInvoke, | ||
| deserialize, | ||
| interceptors.map { | ||
| // Will cause runtime ClassCastExceptions during interceptor invocation if the types don't match. Is that ok? |
Contributor
There was a problem hiding this comment.
Nit: The comment is useful but Is that ok? seems like it could be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Resolves #1577
Description of changes
Adds support for
getItem(partitionKey: PK)andgetItem(partitionKey: PK, sortKey: SK)in DynamoDB Mapper tables by way of a new private interceptor that sets the low-level key before invocation.This change also updates the
Operationtype to adata classto provide an easycopymethod which can insert the new interceptor into an operation created by one of the codegen factory methods. TheOperationtype isinternalso there's no concern about public API compatibility.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.