feat: release readiness - smithy-kotlin branch check #1586
Conversation
0marperez
added
the
no-changelog
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view.
|
7 similar comments
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view.
|
5 similar comments
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view.
|
0marperez
force-pushed
the
release-readiness-v2
branch
from
1b2f224 to
9a810cd
Compare
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
| uses: actions/checkout@v4 | ||
| with: | ||
| path: 'aws-sdk-kotlin' | ||
| ref: '${{ github.head_ref }}' |
There was a problem hiding this comment.
Is this configuration necessary? I think it's the default behavior:
When checking out the repository that triggered a workflow, this defaults to the reference or SHA for that event.
There was a problem hiding this comment.
I think so, when I was testing and making changes before, git branch --show-current was failing because the default behavior is to checkout a commit only not the whole branch.
There was a problem hiding this comment.
Instead of using git branch --show-current can't you just use the GITHUB_HEAD_REF environment variable that's set by default? https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#default-environment-variables
| with: | ||
| path: 'aws-sdk-kotlin' | ||
| ref: '${{ github.head_ref }}' | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
Why do we need to fetch all history rather than the default (1)?
There was a problem hiding this comment.
I think we can remove this, I don't think it matters. This is left over from testing. I'll remove it and see if the workflow still works.
| echo "::error::Matching smithy-kotlin and aws-sdk-kotlin branches but no smithy-kotlin version bump" | ||
| exit 1 | ||
| else | ||
| echo "::warning::Matching smithy-kotlin and aws-sdk-kotlin branches with smithy-kotlin version bump detected" |
There was a problem hiding this comment.
I think there's a small chance someone makes a change to the smithy version lines that's not a version bump, and a warning could help someone debug.
There was a problem hiding this comment.
Not a strong opinion but I think if there's matching smithy-kotlin and aws-sdk-kotlin branches, and we do a version bump, that's expected behavior and shouldn't be a warning?
There was a problem hiding this comment.
Agreed, this should be info.
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
… release-readiness-v2
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
|
|
A new generated diff is ready to view.
|
Affected ArtifactsChanged in size
|
3 participants
Issue #
Description of changes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.