Early return if no extension separator found. Include a descriptive c…

…omment too
aws · Jun 30, 2024 · cbeb741 · cbeb741
1 parent 07145c6
commit cbeb741
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/sdk/src/Core/Amazon.Util/AWSSDKUtils.cs b/sdk/src/Core/Amazon.Util/AWSSDKUtils.cs
@@ -204,7 +204,15 @@ public static string GetExtension(string path)
                 return null;
 
 #if NET8_0_OR_GREATER
+            // LastIndexOf and LastIndexOfAny is vectorized on .NET8+ and is
+            // signifigantly faster for cases where 'path' does not end with a short file
+            // extension, such as GUIDs
             int extensionIndex = path.AsSpan().LastIndexOf('.');
+            if (extensionIndex == -1)
+            {
+                return string.Empty;
+            }
+
             int directoryIndex = path.AsSpan().LastIndexOfAny('/', '\\', ':');
 
             // extension separator is found and exists before path separator or path separator doesn't exist