Skip to content

Elastic Transcoder requires empty string for notifications that are not required #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phillip-haydon opened this issue Mar 14, 2016 · 5 comments
Labels
guidance Question that needs advice or information.

Comments

@phillip-haydon
Copy link

During the creation of a pipeline:

Client.CreatePipeline(new CreatePipelineRequest
            {
                *snip*
                Notifications = new Notifications
                {
                    Completed = "arn:aws:sns:us-east-1:******:Video-Media-Completed",
                    Error = "",
                    Progressing = "",
                    Warning = ""
                }
            })

If you don't specify the un-required notifications:

e.g

                Notifications = new Notifications
                {
                    Completed = "arn:aws:sns:us-east-1:******:Video-Media-Completed"
                }

It throws an error saying:

The "Error" field is not allowed to be null., The "Progressing" field is not allowed to be null., The "Warning" field is not allowed to be null.

This makes no sense considering the values can be an empty string to specify that there are no notifications to be raised for these events.

null should be allowed.

@gokarnm
Copy link
Contributor

gokarnm commented Mar 23, 2016

I agree with you that this is a poor experience. Unfortunately, this is the current service behavior. We have forwarded your feedback to the Elastic Transcoder team and they have added a backlog task to improve this functionality.

@gokarnm gokarnm closed this as completed Mar 23, 2016
@phillip-haydon
Copy link
Author

@gokarnm I disagree. This can be fixed in the SDK without needing to touch core transcoder, just default the values in the SDK to empty string and don't force me to have to do it, gives a better user experience without having to care about the elastic transcoder implementation.

@phillip-haydon
Copy link
Author

@gorkarnm do you want me to send a PR fixing the ctor?

PavelSafronov pushed a commit that referenced this issue Apr 8, 2016
@PavelSafronov
Copy link

Version 3.1.0.5 of the ElasticTranscoder package now allows you to pass null values for notifications when calling CreatePipeline.

@phillip-haydon
Copy link
Author

Awesome @PavelSafronov thank you very much :)

@diehlaws diehlaws added guidance Question that needs advice or information. and removed Question labels Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidance Question that needs advice or information.
Projects
None yet
Development

No branches or pull requests

4 participants