Optimize DetermineService #3365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmarbach
changed the base branch from
v4-development
to
v4-development-merge
danielmarbach
changed the base branch from
v4-development-merge
to
v4-development
danielmarbach
commented
Jun 30, 2024
| } | ||
|
|
||
| // Compiler trick to directly refer to static data in the assembly | ||
| private static ReadOnlySpan<char> DoubleSlash => new[] { '/', '/' }; |
There was a problem hiding this comment.
@stevenaw you might enjoy this ;)
There was a problem hiding this comment.
That's a neat trick, thanks! I'll have to look out for opportunities to use this
10 tasks
|
@normj @dscpinheiro this is ready |
normj
approved these changes
Jul 4, 2024
dscpinheiro
approved these changes
Jul 4, 2024
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Heavily optimizes DetermineService method which is also used on the Signing request path
Motivation and Context
https://github.com/danielmarbach/aws-sdk-net-benchmarks/blob/main/DetermineService.cs
Proof of embedding (also works on .NET)
https://sharplab.io/#gist:c381a4555b6ad204c609be729ee4e864
Testing
I added a theory test with some inline data to make sure the existing functionality is preserved
Screenshots (if appropriate)
Types of changes
Checklist
License