Fix TransactWrite<T>.AddSaveItem when T does NOT contain DynamoDbProperty Attributes

[irina-herciu]

Description

fix: Fixed an issue where TransactWrite.AddSaveItem throws when T does NOT contain DynamoDbProperty Attributes

given that T does not contain any DynamoDbProperty, in order to use TransactWriteItem API to save the entity, it will require to perform PutItem operation instead of an UpdateItem operation.

Motivation and Context

Issue #3095

Testing

Tested locally using below code:

[Fact]
public async Task GivenCreateMultiTableTransactWrite_WhenAddSaveItem_ShouldSucceed()
{
DynamoDBOperationConfig TransactionDynamoDbOperationConfig = new DynamoDBOperationConfig()
{
SkipVersionCheck = true,
ConditionalOperator = ConditionalOperatorValues.And
};

 var table1 = new Table1() { Id = "Id2", RelatedId = "Id1"};
 var table2 = new Table2() { Id = "Id1", RelatedId = "Id2"};

 IDynamoDBContext dbContext = new DynamoDBContext(new AmazonDynamoDBClient());

 TransactWrite<Table1> t1 = dbContext.CreateTransactWrite<Table1>(TransactionDynamoDbOperationConfig);
 t1.AddSaveItem(table1);

 TransactWrite<Table2> t2 = dbContext.CreateTransactWrite<Table2>(TransactionDynamoDbOperationConfig);
 t2.AddSaveItem(table2);

 MultiTableTransactWrite transaction = dbContext.CreateMultiTableTransactWrite(t1,t2);
 await transaction.ExecuteAsync();

}

[DynamoDBTable("Table1")]
public class Table1
{
[DynamoDBHashKey("Id")]
public string Id { get; set; } = string.Empty;

[DynamoDBRangeKey("RelatedId")]
public string RelatedId { get; set; } = string.Empty;

}

[DynamoDBTable("Table2")]
public class Table2
{
[DynamoDBHashKey("Id")]
public string Id { get; set; } = string.Empty;

[DynamoDBRangeKey("RelatedId")]
public string RelatedId { get; set; } = string.Empty;

[DynamoDBProperty("NonKey")]
public string NonKey { get; set; } = string.Empty;

}

Screenshots (if appropriate)

Types of changes

• [ x] Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• [ x] My code follows the code style of this project
• My change requires a change to the documentation
• I have updated the documentation accordingly
• [ x] I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed

License

• [ x ] I confirm that this pull request can be released under the Apache 2 license

[normj]

We need a test for this change. I would suggest adding a test to sdk\test\Services\DynamoDBv2\IntegrationTests\DataModelTests.cs.

Also as you create PRs you need to add a change file so the release system will know to update the version and generate the change log. For this PR you would add a file generator/.DevConfigs/<random-guid>.json here with the following content. Feel free to tweak the message.

{
  "services": [
    {
      "serviceName": "DynamoDBv2",
      "type": "patch",
      "changeLogMessages": [
        "Fixed issue with TransactWrite using the DataModel not handling when only keys are being saved."
      ]
    }
  ]
}

[normj]

Changes look good. Running the change through the internal validation system.

[normj]

Internal dry run successful.

[dscpinheiro]

@irina-herciu Thanks again for the contribution, this PR will be included in today's release of the SDK (I'll update the linked issue with the version number once the new package is available).