Skip to content

Conversation

@GarrettBeatty
Copy link
Contributor

@GarrettBeatty GarrettBeatty commented Oct 29, 2025

Stacked PRs:


Description

This change creates a new api UploadWithResponseAsync. It is the same as the existing UploadAsync api but it returns the TransferUtilityUploadResponse object.

How

In order to re-use as much as the existing code as possible, I made BaseCommand take in a generic which is the return type of the ExecuteAsync function. All commands UploadCommand, DownloadCommand, etc will pass in their expected return type TransferUtilityUploadResponse, TransferUTilityDownloadResponse, etc.

In order to make this change in one go, I had to create place holder classes for TransferUtilityDownloadDirectoryResponse and other responses. These will eventually be populated in future PRs

Motivation and Context

  1. To adhere to the SEP

Testing

1.dry run - d704b36b-7329-42dc-80e0-525a2f82bbcc pass
2. Integration tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@@ -0,0 +1,35 @@
/*******************************************************************************
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

placeholder class. not sure if we need to populate abort upload but i had to make it anyway

*/

using Amazon.Runtime;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be populated later on

@GarrettBeatty GarrettBeatty changed the base branch from GarrettBeatty/stacked/9 to feature/transfermanager October 29, 2025 21:21
@GarrettBeatty GarrettBeatty force-pushed the GarrettBeatty/stacked/11 branch from 5dc5389 to d25d972 Compare October 29, 2025 21:22
@GarrettBeatty GarrettBeatty changed the base branch from feature/transfermanager to GarrettBeatty/stacked/9 October 29, 2025 21:22
@GarrettBeatty GarrettBeatty changed the base branch from GarrettBeatty/stacked/9 to feature/transfermanager October 29, 2025 22:01
@GarrettBeatty GarrettBeatty force-pushed the GarrettBeatty/stacked/11 branch 2 times, most recently from d2be08f to 2480ffd Compare October 29, 2025 22:01
@GarrettBeatty GarrettBeatty changed the base branch from feature/transfermanager to GarrettBeatty/stacked/9 October 29, 2025 22:01
@GarrettBeatty GarrettBeatty changed the base branch from GarrettBeatty/stacked/9 to feature/transfermanager October 29, 2025 22:51
@GarrettBeatty GarrettBeatty force-pushed the GarrettBeatty/stacked/11 branch from 2480ffd to d6058a5 Compare October 29, 2025 22:51
@GarrettBeatty GarrettBeatty changed the base branch from feature/transfermanager to GarrettBeatty/stacked/9 October 29, 2025 22:51
…psonse objects.

stack-info: PR: #4087, branch: GarrettBeatty/stacked/12
stack-info: PR: #4076, branch: GarrettBeatty/stacked/9
@GarrettBeatty GarrettBeatty changed the base branch from GarrettBeatty/stacked/9 to feature/transfermanager November 3, 2025 14:38
@GarrettBeatty GarrettBeatty force-pushed the GarrettBeatty/stacked/11 branch from d6058a5 to 9498c56 Compare November 3, 2025 14:38
@GarrettBeatty GarrettBeatty changed the base branch from feature/transfermanager to GarrettBeatty/stacked/9 November 3, 2025 14:38
stack-info: PR: #4085, branch: GarrettBeatty/stacked/11
@GarrettBeatty GarrettBeatty changed the base branch from GarrettBeatty/stacked/9 to feature/transfermanager November 3, 2025 14:47
@GarrettBeatty GarrettBeatty force-pushed the GarrettBeatty/stacked/11 branch from 9498c56 to 9368de2 Compare November 3, 2025 14:48
@GarrettBeatty GarrettBeatty changed the base branch from feature/transfermanager to GarrettBeatty/stacked/9 November 3, 2025 14:48
@GarrettBeatty GarrettBeatty force-pushed the GarrettBeatty/stacked/9 branch from 24931db to 6bc2b7b Compare November 6, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants