-
Notifications
You must be signed in to change notification settings - Fork 872
add UploadWithResponseAsync api #4085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
968198d to
5dc5389
Compare
This was referenced Oct 29, 2025
GarrettBeatty
commented
Oct 29, 2025
| @@ -0,0 +1,35 @@ | |||
| /******************************************************************************* | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
placeholder class. not sure if we need to populate abort upload but i had to make it anyway
GarrettBeatty
commented
Oct 29, 2025
| */ | ||
|
|
||
| using Amazon.Runtime; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will be populated later on
GarrettBeatty
commented
Oct 29, 2025
GarrettBeatty
commented
Oct 29, 2025
peterrsongg
approved these changes
Oct 29, 2025
5dc5389 to
d25d972
Compare
d2be08f to
2480ffd
Compare
2480ffd to
d6058a5
Compare
d6058a5 to
9498c56
Compare
stack-info: PR: #4085, branch: GarrettBeatty/stacked/11
9498c56 to
9368de2
Compare
24931db to
6bc2b7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Description
This change creates a new api
UploadWithResponseAsync. It is the same as the existingUploadAsyncapi but it returns theTransferUtilityUploadResponseobject.How
In order to re-use as much as the existing code as possible, I made
BaseCommandtake in a generic which is the return type of theExecuteAsyncfunction. All commandsUploadCommand,DownloadCommand, etc will pass in their expected return typeTransferUtilityUploadResponse,TransferUTilityDownloadResponse, etc.In order to make this change in one go, I had to create place holder classes for
TransferUtilityDownloadDirectoryResponseand other responses. These will eventually be populated in future PRsMotivation and Context
Testing
1.dry run - d704b36b-7329-42dc-80e0-525a2f82bbcc pass
2. Integration tests
Types of changes
Checklist
License