Skip to content

Add Laravel 8 support #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 14, 2020
Merged

Add Laravel 8 support #191

merged 7 commits into from
Sep 14, 2020

Conversation

Kussie
Copy link
Contributor

@Kussie Kussie commented Sep 8, 2020

Description of changes:
Adds support for Laravel 8

Changes:

  • Bump supported version of Illuminate/support to ^8.0
  • Bump the version of dotenv to include support for ^5.0
  • Update docs to show support for Laravel 8

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@flemzord
Copy link

flemzord commented Sep 8, 2020

Laravel 8 is out :)

@Kussie Kussie closed this Sep 8, 2020
@Kussie Kussie reopened this Sep 8, 2020
@Kussie Kussie marked this pull request as ready for review September 8, 2020 21:51
@Kussie
Copy link
Contributor Author

Kussie commented Sep 8, 2020

All green and ready to go

@likeadeckofcards
Copy link

When will this be merged?

@j-fulbright
Copy link

+1

2 similar comments
@huangdijia
Copy link

+1

@sidigi
Copy link

sidigi commented Sep 10, 2020

+1

@SamRemis
Copy link
Member

This needs a changelog, once it is added, it shouldn't take long to merge

@Kussie
Copy link
Contributor Author

Kussie commented Sep 10, 2020

@SamRemis This change is almost the same as the Laravel 7 support branch that was merged (Apart from version numbers). I can add the changes to the changelog.md if that is what you asking, but imho that should be done when a new version is tagged instead, which this is not doing. But regardless also added the exact changes made to the main comment, if you need something else to get this merged let me know and i will jump on it.

@duellsy
Copy link

duellsy commented Sep 11, 2020

@SamRemis Agree with @Kussie on this one, the CHANGELOG.md and the version number should only be bumped when the release is actually tagged, not as part of a PR, as it was with the 3.5.0 release: 7a37054

Are you able to handle this? It's holding up a lot of Laravel 8 upgrades :)

@duellsy
Copy link

duellsy commented Sep 11, 2020

Also tagging @howardlopez for input as they did the last couple of tagged releases 👋

@Cannonb4ll
Copy link

Waiting for this as well 👍

@bradders bradders mentioned this pull request Sep 13, 2020
@martinduefrandsen
Copy link

When will this be merged?

Copy link
Contributor

@howardlopez howardlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks fore the PR @Kussie!

@howardlopez howardlopez merged commit f9ad129 into aws:master Sep 14, 2020
@howardlopez
Copy link
Contributor

Version 3.6.0 has been released with the changes. We appreciate your work on this @Kussie!

@Kussie Kussie deleted the laravel-8-support branch September 14, 2020 22:50
@Kussie Kussie restored the laravel-8-support branch September 14, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.