Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Guzzle 7 #1940

Merged
merged 3 commits into from
Jan 3, 2020
Merged

Allow Guzzle 7 #1940

merged 3 commits into from
Jan 3, 2020

Conversation

Nyholm
Copy link
Contributor

@Nyholm Nyholm commented Dec 30, 2019

We just released a beta of Guzzle 7 today. The BC breaking changes have been kept to a minimum.

This PR allows users to use AWS SDK with Guzzle 7.

@codecov-io
Copy link

codecov-io commented Dec 30, 2019

Codecov Report

Merging #1940 into master will decrease coverage by 0.08%.
The diff coverage is 36.36%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1940      +/-   ##
============================================
- Coverage     93.33%   93.25%   -0.09%     
  Complexity     3504     3504              
============================================
  Files           195      195              
  Lines          9307     9319      +12     
============================================
+ Hits           8687     8690       +3     
- Misses          620      629       +9
Impacted Files Coverage Δ Complexity Δ
src/functions.php 72.22% <36.36%> (-4.3%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35289d9...d70ebf5. Read the comment docs.

src/functions.php Outdated Show resolved Hide resolved
src/functions.php Show resolved Hide resolved
Copy link
Contributor

@howardlopez howardlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a couple comments, and also can you add a changelog?

src/functions.php Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
@Nyholm
Copy link
Contributor Author

Nyholm commented Jan 2, 2020

I updated the PR with Travis config, changelog and a cache.

Im hesitant the cache is needed to be honest. I ran a small test:

Without cache: 0,018428ms
With cache:    0,006540ms

With cache is indeed much faster. It runs in 35% of the time. But this is running 10 million times! So I think it is fair to go without a cache. =)

Especially considering that we are often doing a HTTP call after calling this function.

@howardlopez howardlopez merged commit 4f12570 into aws:master Jan 3, 2020
@Nyholm
Copy link
Contributor Author

Nyholm commented Jan 3, 2020

Thank you for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants