-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Guzzle 7 #1940
Allow Guzzle 7 #1940
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1940 +/- ##
============================================
- Coverage 93.33% 93.25% -0.09%
Complexity 3504 3504
============================================
Files 195 195
Lines 9307 9319 +12
============================================
+ Hits 8687 8690 +3
- Misses 620 629 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Just a couple comments, and also can you add a changelog?
I updated the PR with Travis config, changelog and a cache. Im hesitant the cache is needed to be honest. I ran a small test:
With cache is indeed much faster. It runs in 35% of the time. But this is running 10 million times! So I think it is fair to go without a cache. =) Especially considering that we are often doing a HTTP call after calling this function. |
Thank you for merging. |
We just released a beta of Guzzle 7 today. The BC breaking changes have been kept to a minimum.
This PR allows users to use AWS SDK with Guzzle 7.