Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS::SQS::Queue - use OpenSSL for Digest needs #663

Merged
merged 2 commits into from
Dec 3, 2014
Merged

AWS::SQS::Queue - use OpenSSL for Digest needs #663

merged 2 commits into from
Dec 3, 2014

Conversation

fallwith
Copy link

As with #529 (ee75b78), I would like for AWS::SQS::Queue to switch to using OpenSSL::Digest instead of Digest. Without this change I am running into Digest::Base cannot be directly inherited in Ruby when running multiple MRI threads.

@fallwith
Copy link
Author

fallwith commented Dec 3, 2014

Can someone please take a look at this one?

It looks like every other instance of Digest::MD5 was already converted to OpenSSL::Digest::MD5, and this PR seeks to make that same change to the last remaining instance of Digest::MD5 in the AWS::SQS::Queue class.

Currently we're using multiple threads to listen to SQS queues (one unique queue per thread) and occasionally everything blows up when it hits the Digest::MD5 line. I researched it a bit and found that Digest::MD5 is not thread-safe and that using OpenSSL::Digest::MD5 solves the problem. Then I discovered that the aws-sdk-ruby project had already made the change to OpenSSL for all but one instance of Digest::MD5, so this PR was submitted to get that last instance changed as well.

trevorrowe added a commit that referenced this pull request Dec 3, 2014
AWS::SQS::Queue - use OpenSSL for Digest needs
@trevorrowe trevorrowe merged commit 56926d4 into aws:master Dec 3, 2014
@trevorrowe
Copy link
Member

Thanks for the contribution. This should go out with the next release.

trevorrowe added a commit that referenced this pull request Dec 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants