Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable set ModelClientConfig in TransformerStep #171

Open
ysgit opened this issue Oct 12, 2021 · 3 comments
Open

Unable set ModelClientConfig in TransformerStep #171

ysgit opened this issue Oct 12, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@ysgit
Copy link

ysgit commented Oct 12, 2021

Not sure if this qualifies as a bug or a feature request...

When creating a transform job one can pass a ModelClientConfig containing the invocation timeout and number of retries. See https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_CreateTransformJob.html#sagemaker-CreateTransformJob-request-ModelClientConfig

This is implemented in the sagemaker python sdk, you can set model_client_config when calling Transformer.transform.

There is currently no option to set this in the TransformerStep

It should be relatively easy to implement by adding model_client_config as a param to the TransformerStep and setting parameters['ModelClientConfig'] to the value passed there.


This is 🐛 Bug Report

@ysgit ysgit added the bug Something isn't working label Oct 12, 2021
@ca-nguyen
Copy link
Contributor

Hi @ysgit

Thank you reporting this!

We are currently working on exposing the TransformStep parameters in the step constructor. With this change, any parameters documented in CreateTransformJob will be dynamically configurable.

Current PR for this change: #157

@ca-nguyen ca-nguyen added enhancement New feature or request and removed bug Something isn't working labels Oct 15, 2021
@shivlaks
Copy link
Contributor

@ca-nguyen - PR #157 is currently classified as a feature. If it is a bug, let's make sure we add the template information captured for posterity (repro steps, expected behaviour, observed behaviour, etc).

The template information really helps in clarifying the problem and resolves ambiguity :)

@RGirish
Copy link

RGirish commented Jul 19, 2022

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants