Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow Tags are not updated #190

Open
lasdem opened this issue Aug 9, 2022 · 1 comment
Open

Workflow Tags are not updated #190

lasdem opened this issue Aug 9, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@lasdem
Copy link

lasdem commented Aug 9, 2022

I have created two workflows with the SDK.
Later I wanted to update the workflows using the SDK and adding tags.
I provided a list of tags in the constructor, but when viewing the workflow in the AWS UI I do not see any tags on my workflows.

Reproduction Steps

import stepfunctions
from stepfunctions.workflow import Workflow
from stepfunctions.steps import *

workflow_execution_role = "<ENTER A VALID EXECUTION ROLE>"
hello_workflow_name='hello_workflow'
hello_step = Pass(state_id="HelloWorld")

# creating a demo workflow
hello_workflow = Workflow(
    name=hello_workflow_name, 
    definition=hello_step, 
    role=workflow_execution_role
)
hello_workflow_arn = hello_workflow.create()

# now trying to update the existing workflow with tags
hello_workflow_update = Workflow(
    name=hello_workflow_name, 
    definition=hello_step, 
    role=workflow_execution_role,
    state_machine_arn = hello_workflow_arn,
    tags=[
        {"key": "Environment", "value": 'example'},
        {"key": "Owner", "value": 'Lasdem'},
    ]
)
hello_workflow_update.update(hello_step)

What did you expect to happen?

I tried to add tags to an existing workflow

What actually happened?

No Tags appeared after the update of the workflow.

Environment

  • AWS Step Functions Data Science Python SDK version : 2.3.0
  • Python Version: Python 3.8.13

Other


This is 🐛 Bug Report

@lasdem lasdem added the bug Something isn't working label Aug 9, 2022
@evaie
Copy link

evaie commented Nov 30, 2023

Hello,
I can confirm the same problem with the current version:

workflow = Workflow(
name=role_radix+"_sfn_sdk_training_pipeline_abalone",
definition=workflow_definition,
role=sagemaker_execution_role,
execution_input=execution_input,
tags=mes_tags,
)

has no effect on the ASL produced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants