feat: Support placeholders for TuningStep #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca-nguyen
force-pushed
the
support-placeholders-for-tuning-step
branch
from
8569fa0 to
5991cf8
Compare
ca-nguyen
force-pushed
the
support-placeholders-for-tuning-step
branch
from
5991cf8 to
39640f8
Compare
evscott
previously approved these changes
Oct 20, 2021
ca-nguyen
dismissed
shivlaks’s stale review
Comments were addressed and PR was updated per suggestions in the last commit
shivlaks
reviewed
Oct 27, 2021
Co-authored-by: Shiv Lakshminarayan <shivlaks@amazon.com>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
jormello
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support to define Hyperparameters Tuning parameters dynamically using placeholders
Fixes #85
Why is the change necessary?
Currently, it is not possible to use placeholders for Sagemaker Hyperparameters Tuning properties. The properties cannot be defined dynamically, as they need to be defined in the HyperparameterTuner which does not accept placeholders.
This change makes it possible to use placeholders for HyperparameterTuner properties by using the parameters field that are passed down from the TuningStep.
Solution
Use the
parametersfield that is compatible with placeholders to define TuningStep properties.Merge the parameters that were generated from the HyperparameterTuner with the input parameters:
data- which requires RecordSets as data depending on the estimator used to define the tuner.Testing
Added unit and integration tests
Pull Request Checklist
Please check all boxes (including N/A items)
Testing
Documentation
Title and description
Fixes #xxxBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.