-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Update AWS Glue Databrew StartJobRun step to use integration pattern input #176
Merged
ca-nguyen
merged 8 commits into
aws:main
from
ca-nguyen:update-glue-databrew-integration
Nov 15, 2021
Merged
refactor: Update AWS Glue Databrew StartJobRun step to use integration pattern input #176
ca-nguyen
merged 8 commits into
aws:main
from
ca-nguyen:update-glue-databrew-integration
Nov 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivlaks
approved these changes
Nov 2, 2021
shivlaks
previously requested changes
Nov 2, 2021
ca-nguyen
dismissed
shivlaks’s stale review
November 2, 2021 23:29
Suggested changes were added in last commit
shivlaks
reviewed
Nov 4, 2021
Co-authored-by: Shiv Lakshminarayan <shivlaks@amazon.com>
shivlaks
previously approved these changes
Nov 5, 2021
evscott
approved these changes
Nov 8, 2021
jormello
approved these changes
Nov 12, 2021
kwargs[Field.Resource.value] = get_service_integration_arn(GLUE_DATABREW_SERVICE_NAME, | ||
GlueDataBrewApi.StartJobRun, | ||
integration_pattern) | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit (non-blocking): would be good to have the comment precede the Field.Resource assignment.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
7 tasks
shivlaks
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update AWS Glue Databrew service integration to use
integration_pattern
input instead orwait_for_completion
flag.Fixes #(issue) (N/A)
Why is the change necessary?
This change is necessary for consistency with the new service integration implementation pattern introduced in commit (Add support for Nested Step Functions) that uses the
integration_pattern
arg in the step constructor to build the resource.Support for AWS Glue Databrew service integration was added in this commit, but not released yet.
A later commit (Add support for Nested Step Functions) introduced a new implementation pattern using the
IntegrationPattern
enum as input to construct the step instead of thewait_for_completion
flag. (See PR for more detail on rationale behind the implementation).Solution
Replace the
wait_for_completion
flag withintegration_pattern
arg in StartJobRun step construction.The
IntegrationPattern
is used to build theResource
arn as follow:See Service Integration Patterns for more details
Normally, replacing a constructor argument would be a breaking change, but since we have not released support for AWS Glue Databrew service integration yet, it is acceptable to do so. After next release, it making such changes will be considered as not being backward compatible.
Testing
Manual Tests
Create a
Databrew
job for manual tests (<databrew_job_name>).For each test, create a workflow and execute as follow:
Pull Request Checklist
Please check all boxes (including N/A items)
Testing
Documentation
Title and description
Fixes #xxx
- N/ABy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.