Respect IDE HTTP Proxy settings

[kiiadi]

Calls to AWS via the AWS clients should respect the IDE-wide HTTP settings.

We will need to create our own implementation of the SdkHttpClient, the JetBrains framework has a com.intellij.util.net.HttpConfigurable that we can use to create a HttpUrlConnection (which includes IDE proxy settings if present). We should switch from the AWS ApacheHttpClient (and remove the dependency from our dependency closure), to UrlConnectionHttpClient and then update the AWS SDK for Java so that it can accept a proxy configuration per request.

Also need to update software.aws.toolkits.core.utils.RemoteResourceResolver

[abrooksv]

SDK change was released in 2.2.0

[onedaywillcome1]

I downloaded aws toolkit in intellij plugins. Even though proxy is set in intellij network settings, toolkit doesn't connect to aws lambda or cloudformation. What is the situation of this issue? @abrooksv

[abrooksv]

We have not implemented it yet, this is a feature request.

When attempting the change we found a bug in the SDK that will need to be fixed first. aws/aws-sdk-java-v2#975

[abrooksv]

Bugfix against SDK: aws/aws-sdk-java-v2#989

[abrooksv]

Another fix in Java SDK: aws/aws-sdk-java-v2#990

[abrooksv]

Code changes have been made and hidden behind a feature flag to opt-in. There are known issues since the SDK issues have not been merged.

#735

[abrooksv]

Tested the proxy integration does work but UrlConnectionHttpClient fails with signature validation issues against some services, SDK issue: aws/aws-sdk-java-v2#1078

[bikerp]

I'm facing the same issue. We use corporate proxy with authentication and the AWS Toolkit cannot connect to the AWS

[was-av]

I'm facing the same issue too.

[Sipsip]

I have the same issue. Is there a workaround? I'm not very familiar with proxy-settings in general

[abrooksv]

Trying a different approach: aws/aws-sdk-java-v2#1154

[abrooksv]

Proxy support has been re-written and showing good results. Will stay behind an experimental feature flag until we get some real-world users.

[abrooksv]

Experimental support landed in 1.3-EAP.2019.04.04.

@onedaywillcome1 @waSRull @bikerp If you would like to test it with your setup, please enable EAP builds (https://github.com/aws/aws-toolkit-jetbrains#eap-builds) and then enable the feature through the experimental actions system.

Then enable the aws.toolkit.useProxy feature and restart.

[netgitdom]

Works for me through our corporate proxy, thanks.

[bikerp]

@abrooksv Thanks for the update. It works.

[zhangzhx]

This has been released in version 1.3