Restart code analyzer in a read action #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrooksv
force-pushed
the
abrooksv-fixRestartReadAction
branch
from
e9eeef2 to
94fa328
Compare
zhangzhx
approved these changes
Jun 12, 2019
zhangzhx
reviewed
Jun 12, 2019
| CompletableFuture.completedFuture(emptyList()) | ||
| val lambdaFuture = CompletableFuture<List<LambdaFunction>>() | ||
|
|
||
| override fun lambdaFunctions(): CompletableFuture<List<LambdaFunction>> { |
There was a problem hiding this comment.
use = lambdaFuture instead
abrooksv
force-pushed
the
abrooksv-fixRestartReadAction
branch
from
9547143 to
86dc711
Compare
zhangzhx
pushed a commit
that referenced
this pull request
Jun 19, 2019
zhangzhx
pushed a commit
that referenced
this pull request
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Motivation and Context
Related Issue(s)
#1012
Testing
Added test for remote lambda gutter icons
Screenshots (if appropriate)
Checklist
gradlew checksucceedsLicense
I confirm that my contribution is made under the terms of the Apache 2.0 license.