Fix #1011 by adding a heuristic to not detect tests as lambda handlers #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrooksv
reviewed
Apr 6, 2020
...st/software/aws/toolkits/jetbrains/services/lambda/python/PythonLambdaHandlerResolverTest.kt
Outdated
Show resolved
Hide resolved
abrooksv
reviewed
Apr 6, 2020
...st/software/aws/toolkits/jetbrains/services/lambda/python/PythonLambdaHandlerResolverTest.kt
Outdated
Show resolved
Hide resolved
…s-toolkit-jetbrains into werlla/pytestimprovements
abrooksv
reviewed
Apr 6, 2020
...st/software/aws/toolkits/jetbrains/services/lambda/python/PythonLambdaHandlerResolverTest.kt
Outdated
Show resolved
Hide resolved
abrooksv
reviewed
Apr 6, 2020
...st/software/aws/toolkits/jetbrains/services/lambda/python/PythonLambdaHandlerResolverTest.kt
Outdated
Show resolved
Hide resolved
|
The original issue mentions that trying to run a test results in our "create lambda" handler hijacking the test runner. Should we try to tackle that issue as well? |
The youtrack issue seems to indicate that it's a JB bug, but if we filter out the test it should no longer do that? |
abrooksv
reviewed
Apr 7, 2020
| private fun assertHandlerDetermineHandlers(handler: String, shouldBeFound: Boolean) { | ||
| runInEdtAndWait { | ||
| val elementSet = findHandler(handler) | ||
| assertThat(elementSet).hasSize(1) |
There was a problem hiding this comment.
Confused a bit on why this will always be found, if shouldBeFound is false
There was a problem hiding this comment.
Let me change the name. It should be found as a valid candidate handler but then be filtered by determineHandler.
|
/runIntegrationTests |
abrooksv
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Related Issue(s)
#1011
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.