Add copy outputs to outputs table #2194
Conversation
|
/runUiTests |
...s-core/src/software/aws/toolkits/jetbrains/services/cloudformation/stack/OutputsTableView.kt
Outdated
Show resolved
Hide resolved
|
Seems a little funny they all have the copy icon IMO |
I mean maybe, but that's how it already was for the rest of the cfn table |
|
/retryBuilds |
|
I'm wondering if there's a way to change the default behaviour to copy-selected cell rather than copy row - I think that's what customers would expect 99% of the time. |
hunterwerlla
force-pushed
the
werlla/copyOutputs
branch
from
67da9d6 to
d5df669
Compare
That is a good point, that is also easy to do, so changed |
| DynamicTableView.Field(message("cloudformation.stack.outputs.description")) { it.description() }, | ||
| DynamicTableView.Field(message("cloudformation.stack.outputs.export")) { it.exportName() } | ||
| ).apply { component.border = JBUI.Borders.empty() } | ||
| private val key = DynamicTableView.Field<Output>(message("cloudformation.stack.outputs.key")) { it.outputKey() } |
There was a problem hiding this comment.
Is this just for code-style? These no longer need to be broken out right?
There was a problem hiding this comment.
Yeah this change can be reverted now, will do
| table.addMouseListener(ResourceActionPopup(this::selected)) | ||
| } | ||
|
|
||
| private fun selected(): SelectedResource? { |
There was a problem hiding this comment.
awesome - I hated myself for this
|
|
||
| step("Check Logical ID action") { | ||
| resource.click(MouseButton.RIGHT_BUTTON) | ||
| findAndClick("//div[@text='Copy Logical ID']") |
There was a problem hiding this comment.
the copy is actually in a few places I think ...
There was a problem hiding this comment.
We have it in cloudwatch logs as well, but I'm not sure why I put it in there. Copying multiple rows/columns works as expected, so removing it from that as well
hunterwerlla
force-pushed
the
werlla/copyOutputs
branch
from
f62852b to
ac41068
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Screenshot
related issues
#2179
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.