fix(toolkit): Fix/gateway coroutines #6132
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rli
reviewed
Dec 1, 2025
...lkit/jetbrains-gateway/src/software/aws/toolkits/jetbrains/gateway/CawsConnectionProvider.kt
Outdated
Show resolved
Hide resolved
…ing files Address PR aws#6098 review feedback to avoid copying entire Gateway files for IDE version compatibility. Changes: - Replace deprecated coroutine APIs with withContext(getCoroutineBgContext()) - startChildSyncIOBackgroundAsync().await() → withContext - lifetime.launchIOBackground → withContext - lifetime.launchOnUiAnyModality → lifetime.launchOnUi - launchChildSyncIOBackground → withContext - Remove manual CoroutineScope + SupervisorJob creation - Move files to common src/ directory (works across all IDE versions) - Delete duplicated src-242-252/ and src-253+/ versions The withContext API is available in all IDE versions, eliminating the need for version-specific file duplication. Coroutine scopes now properly inherit from parent contexts instead of manually creating SupervisorJobs. Tested: - ✅ Compiles for IDE 2024.2-2025.2 - ✅ Compiles for IDE 2025.3+ - ✅ Detekt code style checks pass
Address PR review feedback to match original invocation semantics. Changed from withContext (which suspends and waits) to launch (fire-and-forget) for: - Publishing environment started notification - Stopping environment and reconnecting
aseemxs
force-pushed
the
fix/gateway-coroutines
branch
from
9f0372e to
0e4b2c9
Compare
rli
approved these changes
Dec 2, 2025
aseemxs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Address PR #6098 review feedback to eliminate file duplication and fix coroutine scope management in Gateway connection providers.
Problem:
src-242-252/andsrc-253+/directoriesCoroutineScope + SupervisorJobinstead of using service-injected scopesSolution:
withContext(getCoroutineBgContext())which works across all IDE versionssrc/directory, eliminating version-specific duplicatesSupervisorJobcreation - scopes now properly inherit from parent contextsChecklist
CHANGELOG if the change is customer-facing in the IDE.
(internal refactor, not customer-facing)
Testing:
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.