Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(settings): log without throwing if default value is provided
Problem: If a user setting has the wrong type, `Settings.instance.get` throws an exception, even if a `defaultValue` is provided. We almost never want that behavior. Example: Settings.instance.get<Object>('files.exclude', Number, 42) Solution: Copy the logic from `AnonymousSettings.get()`. TODO: see if we can de-duplicate the logic.
- Loading branch information