Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C# run command #488
C# run command #488
Changes from all commits
1f3c057
8cdefe6
52cc403
007e1d9
55fda65
d8a5823
caee4d8
7f49004
9c55e1c
86b74d9
b8b72ea
9ea83c1
712fd03
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not obvious to me what "relative function handler means". How about calling it something like "full handler name" or "fully-qualified handler name"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming convention isn't great but it's what was here before. It's actually a bit of a misnomer too--compiled languages don't have any need for a relative pathing to the handler (if you dig into this function, we return the handler unmodified).
I'll see what I can do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So on further analysis, when running the Python handler,
args.handlerName
===relativeOriginalFunctionHandler
andhandlerName
===relativeFunctionHandler
(everything is equal in the case where we aren't debugging since the debug run creates a separate handler file for the SAM run).That being said, this logic might potentially change going forward as we improve our code detection logic for the Python handler (right now, we only pull in the code directory itself, so any dependencies in different directories might not get picked up on SAM build). Let's keep this around a little longer and determine whether or not we need it when we improve that.