feat(amazonq): Create a common langauge server downloader #6148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
reviewed
Dec 4, 2024
justinmk3
reviewed
Dec 4, 2024
justinmk3
reviewed
Dec 4, 2024
justinmk3
reviewed
Dec 4, 2024
justinmk3
reviewed
Dec 4, 2024
|
|
||
| // load the zip contents | ||
| const extractPath = extractToTempFolder ? tempFolder : path.join(tempFolder, name) | ||
| new AdmZip(serverZipTempPath).extractAllTo(extractPath) |
There was a problem hiding this comment.
While we're here, we should try to migrate to the new shared/utilities/zipStream.ts if possible. AdmZip will be removed (not web-compatible; though may be irrelevant for this module(?) but we want to eliminate AdmZip totally to avoid confusion about when to use which)
There was a problem hiding this comment.
👍 i'll make a followup PR to change that
justinmk3
approved these changes
Dec 4, 2024
jpinkney-aws
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
feature/xbranches will not be squash-merged at release time.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.