ci: codecov "patch" check #6150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Problem: Codecov doesn't run in Github Actions. This is because: - The `github.ref == 'master'` condition is incorrect. We want the _target_ branch, not the source branch. - The `|| github.event_name == 'pull_request'` condition was removed in 034257e. Solution: Fix the condition. Note that `github.base_ref` is only defined for pull requests, so we require `github.event_name == 'pull_request'`.
Hweinstock
reviewed
Dec 4, 2024
justinmk3
force-pushed
the
fixcodecov
branch
2 times, most recently
from
d3b8b07 to
a3c0578
Compare
Problem: - We have a bot that attempts to remind contributors about adding tests, but it gets ignored. Solution: - Reintroduce the codecov "patch" check. - Update/fix some other details in the codecov config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
feature/xbranches will not be squash-merged at release time.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.