feat(amazonq): add view summary button in chat #6270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
packages/core/src/codewhisperer/service/transformByQ/transformationResultsViewProvider.ts
Outdated
Show resolved
Hide resolved
ntarakad-aws
approved these changes
Dec 17, 2024
justinmk3
reviewed
Dec 19, 2024
|
/runIntegrationTests |
|
Note to self: try setting |
dhasani23
commented
Dec 31, 2024
| if (!disableJobActions) { | ||
| // Note: buttons can only be clicked once. | ||
| // To get around this, we remove the card after it's clicked and then resubmit the message. |
There was a problem hiding this comment.
Not true. We can set disabled: false to allow buttons to be re-clicked, removing the need to call sendJobSubmittedMessage redundantly on line 386 in the file above.
added 2 commits
December 31, 2024 10:28
|
/runIntegrationTests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A "View summary" button was missing in the chat, which made it difficult for users to re-open their transformation summary once they closed it.
Solution
Add the button.
feature/xbranches will not be squash-merged at release time.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.