Skip to content

Conversation

@roger-zhangg
Copy link
Member

Problem

We removed the test in :https://github.com/aws/aws-toolkit-vscode/pull/8318/files
due to localproxy not mocked correctly.

Solution

Fixed the issue and now adding back these tests.
This test starts a mock server and captures the actual user-agent being sent to make sure we are sending correct UA.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@roger-zhangg roger-zhangg requested a review from a team as a code owner December 2, 2025 22:51
@roger-zhangg roger-zhangg reopened this Dec 2, 2025
@chungjac chungjac merged commit 151f9f0 into aws:master Dec 9, 2025
31 checks passed
PotatoWKY pushed a commit to PotatoWKY/aws-toolkit-vscode that referenced this pull request Dec 9, 2025
## Problem
We removed the test in
:https://github.com/aws/aws-toolkit-vscode/pull/8318/files
due to localproxy not mocked correctly.
## Solution
Fixed the issue and now adding back these tests.
This test starts a mock server and captures the actual user-agent being
sent to make sure we are sending correct UA.

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants