-
Notifications
You must be signed in to change notification settings - Fork 753
feat(lambda): condition check on support lambda managed instance #8392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+67
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
|
✅ I finished the code review, and didn't find any security or code quality issues. |
seshubaws
approved these changes
Dec 5, 2025
Contributor
|
One test failing, seems related |
chungjac
approved these changes
Dec 8, 2025
Will-ShaoHua
approved these changes
Dec 8, 2025
PotatoWKY
pushed a commit
to PotatoWKY/aws-toolkit-vscode
that referenced
this pull request
Dec 9, 2025
…#8392) ## Problem ## Solution replacing previous check with LMI checks for `CapacityProviderConfig` ## Notice: Lambda SDK version 3.731 doesn't have this field yet. And updating the SDK causes a lot of compatible issue. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
replacing previous check with LMI checks for
CapacityProviderConfigNotice: Lambda SDK version 3.731 doesn't have this field yet. And updating the SDK causes a lot of compatible issue.
feature/xbranches will not be squash-merged at release time.