Skip to content

Conversation

@roger-zhangg
Copy link
Member

Problem

Solution

replacing previous check with LMI checks for CapacityProviderConfig

Notice: Lambda SDK version 3.731 doesn't have this field yet. And updating the SDK causes a lot of compatible issue.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@roger-zhangg roger-zhangg requested a review from a team as a code owner December 5, 2025 19:33
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@seshubaws
Copy link
Contributor

One test failing, seems related

AssertError: expected invoke to be called once but was called 0 times     at Object.fail (/codebuild/output/src1003725614/src/github.com/aws/aws-toolkit-vscode/node_modules/sinon/lib/sinon/assert.js:120:25)     at failAssertion (/codebuild/output/src1003725614/src/github.com/aws/aws-toolkit-vscode/node_modules/sinon/lib/sinon/assert.js:66:20)     at Object.assert.<computed> [as calledOnce] (/codebuild/output/src1003725614/src/github.com/aws/aws-toolkit-vscode/node_modules/sinon/lib/sinon/assert.js:95:17)     at Context.<anonymous> (/codebuild/output/src1003725614/src/github.com/aws/aws-toolkit-vscode/packages/core/src/test/lambda/vue/remoteInvoke/remoteInvoke.test.ts:40:26)
--

@roger-zhangg roger-zhangg changed the title feat(Lambda): condition check on support lambda managed instance feat(lambda): condition check on support lambda managed instance Dec 5, 2025
@chungjac chungjac merged commit 5c7fc41 into aws:master Dec 9, 2025
31 checks passed
PotatoWKY pushed a commit to PotatoWKY/aws-toolkit-vscode that referenced this pull request Dec 9, 2025
…#8392)

## Problem


## Solution
replacing previous check with LMI checks for `CapacityProviderConfig`

## Notice: Lambda SDK version 3.731 doesn't have this field yet. And
updating the SDK causes a lot of compatible issue.

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants