Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go 1.13 to Travis #165

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Add Go 1.13 to Travis #165

merged 1 commit into from
Jan 28, 2020

Conversation

gliptak
Copy link
Contributor

@gliptak gliptak commented Dec 30, 2019

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@willarmiros
Copy link
Contributor

Hi @gliptak,
Thank you for your contribution. As you can see the Travis tests are failing with this change, and I believe it's because of this issue. Changing the logic to get get all on v1.13 should fix it. Also, there are some places where the latest Go version is referenced and should be increased.

Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add conditional to L43 to run go get all on Go version 1.13
  • Bump version to 1.13 on L46
  • Bump version to 1.13 on L54

@gliptak gliptak mentioned this pull request Dec 31, 2019
@willarmiros
Copy link
Contributor

willarmiros commented Jan 4, 2020

Hi @gliptak,
It seems like there are lots of errors unrelated to your PR that are nonetheless causing Travis to fail sporadically. My suspicion is #156 had some unintended consequences that lead to this behavior, since it affected BeginSegment. We'll have to do some investigation here and determine if the PR or the tests themselves are broken and make the appropriate fix.

Also, again unrelated to this change, but it appears all the SQL unit tests fail in Go 1.13, which will also require an investigation if it's not fixed by the above. Otherwise your changes look good.

@gliptak
Copy link
Contributor Author

gliptak commented Jan 4, 2020

@willarmiros thank you for the pointers. I will wait for the BeginSegment updates.

As for SQL, .1.12 picks up go: finding github.com/DATA-DOG/go-sqlmock v1.2.0 while 1.13 picks up go: finding github.com/DATA-DOG/go-sqlmock v1.2.0

.travis.yml Outdated Show resolved Hide resolved
@willarmiros
Copy link
Contributor

@gliptak one further change then this should be good to go! Thanks for your patience as we resolve these test failures.

Signed-off-by: Gábor Lipták <gliptak@gmail.com>
@gliptak
Copy link
Contributor Author

gliptak commented Jan 28, 2020

@willarmiros thank you for moving this along. The PR is green.

Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@willarmiros willarmiros merged commit 16d917b into aws:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants