-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Go 1.13 to Travis #165
Conversation
Hi @gliptak, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add conditional to L43 to run
go get all
on Go version 1.13 - Bump version to 1.13 on L46
- Bump version to 1.13 on L54
Hi @gliptak, Also, again unrelated to this change, but it appears all the SQL unit tests fail in Go 1.13, which will also require an investigation if it's not fixed by the above. Otherwise your changes look good. |
@willarmiros thank you for the pointers. I will wait for the As for SQL, |
@gliptak one further change then this should be good to go! Thanks for your patience as we resolve these test failures. |
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
@willarmiros thank you for moving this along. The PR is green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.