Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data race fix #196

Merged
merged 9 commits into from
Mar 3, 2020
Merged

Data race fix #196

merged 9 commits into from
Mar 3, 2020

Conversation

bhautikpip
Copy link
Contributor

Issue #, if available:

Description of changes:

Fix this issue : #164

Added locks to avoid data race.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bhautikpip bhautikpip mentioned this pull request Feb 28, 2020
Closed
srprash
srprash approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@srprash srprash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense. Before merging, have someone else take a look as well.

willarmiros
willarmiros approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bhautikpip bhautikpip merged commit 151a8bc into aws:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willarmiros willarmiros willarmiros approved these changes

@srprash srprash srprash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhautikpip @srprash @willarmiros