Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added IGNORE_ERROR mode for context missing strategy #253

Merged
merged 6 commits into from
Oct 13, 2020
Merged

Added IGNORE_ERROR mode for context missing strategy #253

merged 6 commits into from
Oct 13, 2020

Conversation

bhautikpip
Copy link
Contributor

@bhautikpip bhautikpip commented Oct 8, 2020 •
edited
Loading

Issue #, if available:

Description of changes:

Added IGNORE_ERROR for context missing strategy. Now setting AWS_XRAY_CONTEXT_MISSING to IGNORE_ERROR will just ignore context missing panics.

Addresses Github issue: #251

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bhautikpip bhautikpip mentioned this pull request Oct 8, 2020
Closed
willarmiros
willarmiros approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good addition!

@bhautikpip bhautikpip merged commit 95821db into aws:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willarmiros willarmiros willarmiros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhautikpip @willarmiros