Add check on existing segment #376
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atshaw43
reviewed
Aug 30, 2022
| assert.Equal(t, tc.expectedThrottle, subseg.Throttle) | ||
| assert.Equal(t, tc.expectedError, subseg.Error) | ||
| assert.Equal(t, tc.expectedFault, subseg.Fault) | ||
| } |
There was a problem hiding this comment.
Thanks for the upgraded HTTP check logic and subsegment count check.
Can we have an assert in the case of seg.Subsegments == 0?
Nitpick:
can we move "var subseg *Segment" inside the "if len(seg.Subsegments) > 0 {" conditional.
There was a problem hiding this comment.
@mathn00b
Bumping to the top of your inbox.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get panic when don't init new segment in grpc handler
Description of changes:
With this fix we won't get panic if forget to begin new segment in grpc handler
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.