Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented May 13, 2022

Issue #, if available:

448

Description of changes:

Fixes unshift undefined error which can occur when two identical errors are sent consecutively.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Fixes unshift undefined error which can occur when two identical errors are sent consecutively. Issue described here #448
@ghost ghost self-requested a review as a code owner May 13, 2022 11:42
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.73%. Comparing base (0124e92) to head (c465e93).
Report is 149 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #508      +/-   ##
==========================================
+ Coverage   82.50%   82.73%   +0.22%     
==========================================
  Files          36       36              
  Lines        1743     1743              
==========================================
+ Hits         1438     1442       +4     
+ Misses        305      301       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@carolabadeer carolabadeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@carolabadeer carolabadeer merged commit 16c96c5 into aws:master May 18, 2022
@ghost
Copy link
Author

ghost commented May 19, 2022

@carolabadeer thank you for the review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants