-
Notifications
You must be signed in to change notification settings - Fork 157
Prepares 3.3.7 release #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jj22ee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
willarmiros
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm after addressing comments
CHANGELOG.md
Outdated
| * `aws-xray-sdk-core` updated to 3.3.7 | ||
| * fix: Stop throwing unnecessary errors with adding annotations, metadata, errors [PR #467](https://github.com/aws/aws-xray-sdk-node/pull/467) | ||
| * fix: Fix TS declaration of TraceId to match definition [PR #520](https://github.com/aws/aws-xray-sdk-node/pull/520) | ||
| * fix: Fix prototype pollution issue [PR #529](https://github.com/aws/aws-xray-sdk-node/commit/89769989d46eed9e44d8af743e6fb14ad924d48b) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to PR link
CHANGELOG.md
Outdated
| * Added node 16 testing [PR #513](https://github.com/aws/aws-xray-sdk-node/pull/513) | ||
| * Added opentelemetry JS links to README [PR #514](https://github.com/aws/aws-xray-sdk-node/pull/514) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not include these types of "internal" PRs in the changelog - we only include changes that impact behavior of SDK
Codecov Report
@@ Coverage Diff @@
## master #530 +/- ##
==========================================
+ Coverage 82.34% 82.36% +0.02%
==========================================
Files 36 36
Lines 1756 1758 +2
==========================================
+ Hits 1446 1448 +2
Misses 310 310
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Issue #, if available: N/A
Description of changes:
Similar to #511
Bump AWS X-Ray Javascript SDK components to version
3.3.7and update CHANGELOG.md.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.