Skip to content

Conversation

@carolabadeer
Copy link
Contributor

Issue #, if available: N/A

Description of changes:

Similar to #511

Bump AWS X-Ray Javascript SDK components to version 3.3.7 and update CHANGELOG.md.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@carolabadeer carolabadeer requested a review from a team as a code owner August 18, 2022 22:20
Copy link
Contributor

@jj22ee jj22ee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after addressing comments

CHANGELOG.md Outdated
* `aws-xray-sdk-core` updated to 3.3.7
* fix: Stop throwing unnecessary errors with adding annotations, metadata, errors [PR #467](https://github.com/aws/aws-xray-sdk-node/pull/467)
* fix: Fix TS declaration of TraceId to match definition [PR #520](https://github.com/aws/aws-xray-sdk-node/pull/520)
* fix: Fix prototype pollution issue [PR #529](https://github.com/aws/aws-xray-sdk-node/commit/89769989d46eed9e44d8af743e6fb14ad924d48b)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to PR link

CHANGELOG.md Outdated
Comment on lines 8 to 9
* Added node 16 testing [PR #513](https://github.com/aws/aws-xray-sdk-node/pull/513)
* Added opentelemetry JS links to README [PR #514](https://github.com/aws/aws-xray-sdk-node/pull/514)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not include these types of "internal" PRs in the changelog - we only include changes that impact behavior of SDK

@codecov-commenter
Copy link

Codecov Report

Merging #530 (028e9b9) into master (bf0f26e) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
+ Coverage   82.34%   82.36%   +0.02%     
==========================================
  Files          36       36              
  Lines        1756     1758       +2     
==========================================
+ Hits         1446     1448       +2     
  Misses        310      310              
Impacted Files Coverage Δ
lib/segments/segment.js 79.75% <0.00%> (+0.12%) ⬆️
lib/segments/attributes/subsegment.js 77.92% <0.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@carolabadeer carolabadeer merged commit f432b2d into aws:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants